fix: onboard onto ruff #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Python Benchmark with pytest-benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 43998be | Previous: 22529c1 | Ratio |
|---|---|---|---|
benchmark/benchmark.py::test_exact_shots[ghz-density_matrix q[0], q[1]-9-braket_dm_v2] |
75.95764127945702 iter/sec (stddev: 0) |
153.71055748678359 iter/sec (stddev: 0) |
2.02 |
benchmark/benchmark.py::test_exact_shots[ghz-probability-9-braket_sv] |
44.38111318766544 iter/sec (stddev: 0) |
107.64480950290103 iter/sec (stddev: 0) |
2.43 |
benchmark/benchmark.py::test_exact_shots[qft-expectation z(q[0])-14-braket_sv_v2] |
39.02024107890235 iter/sec (stddev: 0) |
111.87265312130869 iter/sec (stddev: 0) |
2.87 |
benchmark/benchmark.py::test_exact_shots[qft-variance y(q[0])-7-braket_dm_v2] |
104.77167506991243 iter/sec (stddev: 0) |
226.40145215726892 iter/sec (stddev: 0) |
2.16 |
benchmark/benchmark.py::test_nonzero_shots[qft-sample z(q[0])-100-13-braket_sv_v2] |
30.859642495239537 iter/sec (stddev: 0) |
97.55205982732475 iter/sec (stddev: 0) |
3.16 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Ruff is a good linter/formatter that Braket should be looking into. If has speed improvements, good support coverage, and is actively being adopted around the Python community. Additionally, this can drop the number of tools in our tool chain
flake8, isort, black->ruff.In summary, some reasons:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.